risdenk commented on code in PR #840: URL: https://github.com/apache/lucene/pull/840#discussion_r859074624
########## lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/LongFieldSource.java: ########## @@ -147,10 +122,6 @@ protected NumericDocValues getNumericDocValues( return DocValues.getNumeric(readerContext.reader(), field); } - protected MutableValueLong newMutableValueLong() { - return new MutableValueLong(); - } - Review Comment: This wasn't used anywhere besides `getValueFiller` and this was the only difference in `getValueFiller` compared to the base class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org