uschindler commented on code in PR #816:
URL: https://github.com/apache/lucene/pull/816#discussion_r859491311
##########
lucene/core/src/test/org/apache/lucene/util/TestCloseableThreadLocal.java:
##########
@@ -48,4 +49,67 @@ protected Object initialValue() {
return TEST_VALUE;
}
}
+
+ public void testSetGetValueWithMultiThreads() {
+ final int CONCURRENT_THREADS = 5;
Review Comment:
please don't spell local variables in all-upper.
##########
lucene/core/src/test/org/apache/lucene/util/TestCloseableThreadLocal.java:
##########
@@ -48,4 +49,67 @@ protected Object initialValue() {
return TEST_VALUE;
}
}
+
+ public void testSetGetValueWithMultiThreads() {
+ final int CONCURRENT_THREADS = 5;
+ final int LOOPS = 10000;
Review Comment:
this should be multiplied by the test multiplier. We have a function
("atLeast") in the base test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
