[ https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528791#comment-17528791 ]
Kevin Risden commented on LUCENE-10534: --------------------------------------- {quote}although PR840 should probably have it's own Jira for tracking/CHANGES.txt purposes.{quote} yea agreed will separate it out into its own Jira. {quote}I don't see any new tests in either of your PRs ... did you forget to 'git add' ?{quote} I didn't add any new correctness tests to the Min/Max PR yet. I've been working on a few JMH tests to see if there is really a performance improvement. I'll push those up to github shortly. I'll go back to add the tests shortly. {quote}Looks like BytesRefFieldSource has the exact same structure (but with a null check instead of a 0.0f check) {quote} Thanks I'll take a look at BytesRefFieldSource > MinFloatFunction / MaxFloatFunction exists check can be slow > ------------------------------------------------------------ > > Key: LUCENE-10534 > URL: https://issues.apache.org/jira/browse/LUCENE-10534 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Kevin Risden > Assignee: Kevin Risden > Priority: Minor > Attachments: flamegraph.png, flamegraph_getValueForDoc.png > > Time Spent: 50m > Remaining Estimate: 0h > > MinFloatFunction > (https://github.com/apache/lucene/blob/main/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MinFloatFunction.java) > and MaxFloatFunction > (https://github.com/apache/lucene/blob/main/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MaxFloatFunction.java) > both check if values exist. This is needed since the underlying valuesource > returns 0.0f as either a valid value or as a value when the document doesn't > have a value. > Even though this is changed to anyExists and short circuits in the case a > value is found in any document, the worst case is that there is no value > found and requires checking all the way through to the raw data. This is only > needed when 0.0f is returned and need to determine if it is a valid value or > the not found case. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org