[
https://issues.apache.org/jira/browse/LUCENE-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529027#comment-17529027
]
Greg Miller commented on LUCENE-10530:
--------------------------------------
Instead of increasing the acceptable delta, I'd prefer to ensure we sum the
floats in the same order and then expect them to be exactly equal. This should
be a more robust solution than fiddling with the delta every time we trip a
random case that breaks things. The issue is that we keep track of all float
values we index for the purpose of determining "expected" sums, but the order
ends up differing from the order we visit the values when iterating the index.
I think I have a solution that lets us reconcile this ordering difference.
> TestTaxonomyFacetAssociations test failure
> ------------------------------------------
>
> Key: LUCENE-10530
> URL: https://issues.apache.org/jira/browse/LUCENE-10530
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Vigya Sharma
> Priority: Major
>
> TestTaxonomyFacetAssociations.testFloatAssociationRandom seems to have some
> flakiness, it fails on the following random seed.
> {code:java}
> ./gradlew test --tests
> TestTaxonomyFacetAssociations.testFloatAssociationRandom \
> -Dtests.seed=4DFBA8209AC82EB2 -Dtests.slow=true -Dtests.locale=fr-VU \
> -Dtests.timezone=Europe/Athens -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8 {code}
> This is because of a mismatch in (SUM) aggregated multi-valued,
> {{float_random}} facet field. We accept an error delta of 1 in this
> aggregation, but for the failing random seed, the delta is 1.3. Maybe we
> should change this delta to 1.5?
> My hunch is that it is some floating point approximation error. I'm unable to
> repro it without the randomization seed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
