[ https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530743#comment-17530743 ]
Kevin Risden commented on LUCENE-10534: --------------------------------------- [~hossman] I added some edge case tests to https://github.com/apache/lucene/pull/837 > MinFloatFunction / MaxFloatFunction calls exists twice > ------------------------------------------------------ > > Key: LUCENE-10534 > URL: https://issues.apache.org/jira/browse/LUCENE-10534 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Kevin Risden > Assignee: Kevin Risden > Priority: Minor > Attachments: flamegraph.png, flamegraph_getValueForDoc.png > > Time Spent: 1h 10m > Remaining Estimate: 0h > > MinFloatFunction > (https://github.com/apache/lucene/blob/main/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MinFloatFunction.java) > and MaxFloatFunction > (https://github.com/apache/lucene/blob/main/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MaxFloatFunction.java) > both check if values exist twice. This change prevents the duplicate exists > check. > Tested with JMH here: https://github.com/risdenk/lucene-jmh > | Benchmark | Mode | > Cnt | Score and Error | Units | > |-----------------------------------------------------------------|-------|-----|------------------|-------| > | MyBenchmark.testMaxFloatFunction | thrpt | > 25 | 64.159 ± 2.031 | ops/s | > | MyBenchmark.testNewMaxFloatFunction | thrpt | > 25 | 94.997 ± 2.365 | ops/s | > | MyBenchmark.testMaxFloatFunctionRareField | thrpt | > 25 | 244.921 ± 6.439 | ops/s | > | MyBenchmark.testNewMaxFloatFunctionRareField | thrpt | > 25 | 239.288 ± 5.136 | ops/s | -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org