rmuir commented on PR #875: URL: https://github.com/apache/lucene/pull/875#issuecomment-1121772167
I kinda feel like in this case we are trying to outsmart the JIT compiler with optimizations it has for `Arrays.equals()`. I understand the idea that we could be smarter based on the data ... maybe ... but I don't think we "know enough". I'd rather us know exactly what that threshold is and write appropriate metadata (e.g. min/maxTermLength) if we can figure it out, better than causing regressions for some use-cases. bonus if any additional metadata metadata can be utilized by checkindex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
