[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537819#comment-17537819
]
ASF subversion and git services commented on LUCENE-10564:
----------------------------------------------------------
Commit b567162fe1af1dad3b3e19c767971c339eecb19d in lucene-solr's branch
refs/heads/branch_8_11 from Julie Tibshirani
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b567162fe1a ]
LUCENE-10564: Make sure SparseFixedBitSet#or updates memory usage (#882)
Before, it didn't update the estimated memory usage, so calls to ramBytesUsed
could be totally off.
> SparseFixedBitSet#or doesn't update memory accounting
> -----------------------------------------------------
>
> Key: LUCENE-10564
> URL: https://issues.apache.org/jira/browse/LUCENE-10564
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Julie Tibshirani
> Priority: Minor
> Fix For: 9.2
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> While debugging why a cache was using way more memory than expected, one of
> my colleagues noticed that {{SparseFixedBitSet#or}} doesn't update
> {{{}ramBytesUsed{}}}. Here's a unit test that demonstrates this:
> {code:java}
> public void testRamBytesUsed() throws IOException {
> BitSet bitSet = new SparseFixedBitSet(1000);
> long initialBytesUsed = bitSet.ramBytesUsed();
> DocIdSetIterator disi = DocIdSetIterator.all(1000);
> bitSet.or(disi);
> assertTrue(bitSet.ramBytesUsed() > initialBytesUsed);
> }
> {code}
> It also looks like we don't have any tests for {{SparseFixedBitSet}} memory
> accounting (unless I've missed them!) It'd be nice to add more coverage there
> too.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
