[ https://issues.apache.org/jira/browse/LUCENE-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540708#comment-17540708 ]
Michael McCandless commented on LUCENE-10586: --------------------------------------------- +1 > Minor refactoring in Lucene90BlockTreeTermsReader local variables: metaIn, > indexMetaIn, termsMetaIn > --------------------------------------------------------------------------------------------------- > > Key: LUCENE-10586 > URL: https://issues.apache.org/jira/browse/LUCENE-10586 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Tomoko Uchida > Priority: Trivial > > Those three local variables refer to the same {{IndexInput}} object (no > clone() is called). > {code} > indexMetaIn = termsMetaIn = metaIn; > {code} > I'm not sure but maybe there are some historical reasons. I wonder if it > would be better to have only one reference for the underlying {{IndexInput}} > object to make it a little easy to follow the code. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org