gautamworah96 opened a new pull request, #922:
URL: https://github.com/apache/lucene/pull/922

   ### Description (or a Jira issue link if you have one)
   
   Change the index option for FacetField to just index the DOCS and not the 
frequencies and offsets (we don't use these values). I still need to think a 
bit more about the long term implications of this change. Opening this PR as a 
starting point for now.
   
   ### Tests
   
   Existing tests pass. I looked for all instances where the code was 
traversing through the postings list in the facet module and none of them were 
relying on the frequency of the term (this is something that confused me at 
first, do we have no use cases for `FacetField` that rely on the frequency? 
apparently not.. If a use case does come up we could change the field type 
again).
   
   
   ### Benchmarks
   
   I ran the `wikimediumall` benchmark with a modified localrun.py script that 
used a new index for the candidate and it did not show any sizeable QPS 
changes. Size of the `facet` index also remained the same at 64 MB.
   
   
   ### Backwards compatibility
   
   I've not thought about this in depth (yet). Existing back-compat tests in 
branch_9x pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to