jtibshirani commented on code in PR #924:
URL: https://github.com/apache/lucene/pull/924#discussion_r885955544
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/Lucene92HnswVectorsFormat.java:
##########
@@ -151,10 +131,6 @@ public KnnVectorsReader fieldsReader(SegmentReadState
state) throws IOException
@Override
public String toString() {
- return "lucene92HnswVectorsFormat(name = lucene92HnswVectorsFormat,
maxConn = "
- + maxConn
- + ", beamWidth="
- + beamWidth
- + ")";
+ return "lucene92HnswVectorsFormat";
Review Comment:
Oh nevermind, I see this matches the codec name (which was accidentally
lower case). And I don't think we can just change the codec name, we need to
keep it the way it is for backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
