gsmiller commented on code in PR #999:
URL: https://github.com/apache/lucene/pull/999#discussion_r911970890
##########
lucene/core/src/java/org/apache/lucene/search/WANDScorer.java:
##########
@@ -368,22 +406,24 @@ private void advanceHead(int target) throws IOException {
}
}
- private void advanceTail(DisiWrapper disi) throws IOException {
+ private DisiWrapper advanceTail(DisiWrapper disi) throws IOException {
Review Comment:
Maybe a short javadoc comment here and on the other `advanceTail` method
that it returns the advanced disi only if it gets added to the leads? I guess
it's pretty obvious when looking at it, but never hurts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
