[ 
https://issues.apache.org/jira/browse/LUCENE-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561789#comment-17561789
 ] 

Zach Chen commented on LUCENE-10635:
------------------------------------

I like this idea! This approach should also be able to preserve most of the 
assertions in the test utilities. I can give it a try and see how things might 
look.

> Ensure test coverage for WANDScorer after additional scorers get added
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-10635
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10635
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Zach Chen
>            Priority: Major
>
> This is a follow-up issue from discussions 
> [https://github.com/apache/lucene/pull/972#issuecomment-1170684358] & 
> [https://github.com/apache/lucene/pull/972#pullrequestreview-1024377641] .
>  
> As additional scorers such as BlockMaxMaxscoreScorer get added, some tests in 
> TestWANDScorer that used to test WANDScorer now test BlockMaxMaxscoreScorer 
> instead, reducing test coverage for WANDScorer. We would like to see how we 
> can ensure TestWANDScorer reliably tests WANDScorer, perhaps by initiating 
> the scorer directly inside the tests?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to