[GitHub] [lucene] zacharymorn commented on a diff in pull request #1005: LUCENE-10636: Avoid computing the same scores multiple times.

[GitBox]

zacharymorn commented on code in PR #1005:
URL: https://github.com/apache/lucene/pull/1005#discussion_r913203251


##########
lucene/core/src/java/org/apache/lucene/search/BlockMaxMaxscoreScorer.java:
##########
@@ -35,11 +34,13 @@ class BlockMaxMaxscoreScorer extends Scorer {
   // heap of scorers ordered by doc ID
   private final DisiPriorityQueue essentialsScorers;
 
-  // list of scorers ordered by maxScore
-  private final LinkedList<DisiWrapper> maxScoreSortedEssentialScorers;
-
+  // array of scorers ordered by maxScore
   private final DisiWrapper[] allScorers;
 
+  // index of the first essential scorer is the `allScorers` array. All 
scorers before this index

Review Comment:
   ```suggestion
     // index of the first essential scorer in the `allScorers` array. All 
scorers before this index
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org