gsmiller commented on code in PR #1004:
URL: https://github.com/apache/lucene/pull/1004#discussion_r915237424
##########
lucene/memory/src/test/org/apache/lucene/index/memory/TestMemoryIndexAgainstDirectory.java:
##########
@@ -533,14 +533,14 @@ public void testDocValuesMemoryIndexVsNormalIndex()
throws Exception {
controlLeafReader.getSortedSetDocValues("sorted_set");
assertEquals(0, controlSortedSetDocValues.nextDoc());
assertEquals(controlSortedSetDocValues.getValueCount(),
sortedSetDocValues.getValueCount());
- for (long controlOrd = controlSortedSetDocValues.nextOrd();
- controlOrd != SortedSetDocValues.NO_MORE_ORDS;
- controlOrd = controlSortedSetDocValues.nextOrd()) {
+ for (int i = 0; i < controlSortedSetDocValues.docValueCount(); i++) {
Review Comment:
Good catch on needing to use `docValueCount()` instead of `getValueCount()`
here! I'd missed that when reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
