vigyasharma opened a new pull request, #1011: URL: https://github.com/apache/lucene/pull/1011
`TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler` fails with the following exception ([build job](https://jenkins.thetaphi.de/job/Lucene-main-Linux/35576/testReport/junit/org.apache.lucene/TestMergeSchedulerExternal/testSubclassConcurrentMergeScheduler/)): ```java java.lang.AssertionError at __randomizedtesting.SeedInfo.seed([DDD39440C0DA45D4:5A5229EDC4FA3FD0]:0) at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertTrue(Assert.java:53) at org.apache.lucene.TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler(TestMergeSchedulerExternal.java:149) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ... at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850) at java.base/java.lang.Thread.run(Thread.java:833) ``` I tried beasting this test but was unable to repro the error. Going by code, we may be hitting `writer.rollback()` too soon. An exception in `addDocument()`, would cause us to skip `getMergeScheduler().sync()` and directly invoke `writer.rollback()`. This *could* cause merge threads to start aborting before they hit the merge exception expected by this test. Since `MergeAbortedException` is not rethrown, it would not hit `mergeScheduler.handleMergeExceptions()`, and the `excCalled` flag would stay unset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
