mikemccand commented on code in PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#discussion_r917872038
########## migration/src/jira2github_import.py: ########## @@ -69,45 +70,53 @@ def convert_issue(num: int, dump_dir: Path, output_dir: Path, account_map: dict[ attachment_list_items = [] att_replace_map = {} for (filename, cnt) in attachments: - attachment_list_items.append(f"- [{filename}]({attachment_url(num, filename, att_repo, att_branch)})" + (f" (versions: {cnt})\n" if cnt > 1 else "\n")) + attachment_list_items.append(f"[{filename}]({attachment_url(num, filename, att_repo, att_branch)})" + (f" (versions: {cnt})" if cnt > 1 else "")) att_replace_map[filename] = attachment_url(num, filename, att_repo, att_branch) + print(f'{jira_id}: attachments: {attachment_list_items}') Review Comment: Woops sorry yes I'll remove all the prints I added! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org