luyuncheng commented on PR #1034: URL: https://github.com/apache/lucene/pull/1034#issuecomment-1187675144
> The logic makes sense to me, can you add unit tests? Thanks for your review, in commits [926dd](https://github.com/luyuncheng/lucene/commit/926dd0c159c314430a6ace3ec55e50f7ee155b56) i added check for the direct memory, and i added unit tests for different allocator in copyBytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
