[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571529#comment-17571529
]
Marios Trivyzas edited comment on LUCENE-10662 at 7/28/22 3:06 PM:
-------------------------------------------------------------------
[~dweiss] Thx! Checkout how it looks like without the renaming:
[https://github.com/apache/lucene/pull/1049/commits/7d58ed9b219ec48b9a00f3dbc051ebcdaafe24c8|https://github.com/apache/lucene/pull/1049/commits/7b71302c915bc8eeee1d9d29ad49f1e917c219ee]
was (Author: matriv):
[~dweiss] Thx! Checkout how it looks like without the renaming:
https://github.com/apache/lucene/pull/1049/commits/7b71302c915bc8eeee1d9d29ad49f1e917c219ee
> Make LuceneTestCase to not extend from org.junit.Assert
> -------------------------------------------------------
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
> Reporter: Marios Trivyzas
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
