[ 
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572569#comment-17572569
 ] 

Deepika Sharma commented on LUCENE-10544:
-----------------------------------------

Since query timeout feature is implemented through BulkScorer class, should  
there be changes made such that  ExitableTermsEnum  wraps postings/impacts 
along with timeout checks in it?

> Should ExitableTermsEnum wrap postings and impacts?
> ---------------------------------------------------
>
>                 Key: LUCENE-10544
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10544
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Greg Miller
>            Priority: Major
>
> While looking into options for LUCENE-10151, I noticed that 
> {{ExitableDirectoryReader}} doesn't actually do any timeout checking once you 
> start iterating postings/impacts. It *does* create a {{ExitableTermsEnum}} 
> wrapper when loading a {{{}TermsEnum{}}}, but that wrapper doesn't do 
> anything to wrap postings or impacts. So timeouts will be enforced when 
> moving to the "next" term, but not when iterating the postings/impacts 
> associated with a term.
> I think we ought to wrap the postings/impacts as well with some form of 
> timeout checking so timeouts can be enforced on long-running queries. I'm not 
> sure why this wasn't done originally (back in 2014), but it was questioned 
> back in 2020 on the original Jira SOLR-5986. Does anyone know of a good 
> reason why we shouldn't enforce timeouts in this way?
> Related, we may also want to wrap things like {{seekExact}} and {{seekCeil}} 
> given that only {{next}} is being wrapped currently.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to