[
https://issues.apache.org/jira/browse/LUCENE-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578489#comment-17578489
]
ASF subversion and git services commented on LUCENE-10678:
----------------------------------------------------------
Commit d426ff43c719acda20f5fc97a26f9f0774a36284 in lucene-solr's branch
refs/heads/branch_8_11 from Ignacio Vera
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d426ff43c71 ]
LUCENE-10678: Fix potential overflow when computing the partition point on the
BKD tree (#1065) (#2668)
We currently compute the partition point for a set of points by multiplying the
number of nodes that needs to be on
the left of the BKD tree by the maxPointsInLeafNode. This multiplication is
done on the integer space so if the partition point is bigger than
Integer.MAX_VALUE it will overflow.
This commit moves the multiplication to the long space so it doesn't overflow.
> computing the partition point on a BKD tree merge can overflow
> --------------------------------------------------------------
>
> Key: LUCENE-10678
> URL: https://issues.apache.org/jira/browse/LUCENE-10678
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Ignacio Vera
> Assignee: Ignacio Vera
> Priority: Major
> Fix For: 8.11.3, 9.4, 9.3.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I just discover a bad bug in the BKD tree when doing merges. Before calling
> the BKDTreeRadix selector we need to compute the partition point which is
> dome multiplying two integers. If the partition point is > Integer.MAX_VALUE
> then it will overflow.
> https://github.com/apache/lucene/blob/35ca2d79f73c6dfaf5e648fe241f7e0b37084a90/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java#L2021
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
