mayya-sharipova commented on code in PR #1071:
URL: https://github.com/apache/lucene/pull/1071#discussion_r949691151
##########
lucene/core/src/java/org/apache/lucene/index/VectorValues.java:
##########
@@ -192,36 +176,5 @@ public int advance(int target) throws IOException {
public long cost() {
return size();
}
-
- @Override
- public RandomAccessVectorValues randomAccess() throws IOException {
Review Comment:
Very nice simplification!
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##########
@@ -133,7 +132,7 @@ private HnswGraphBuilder(
* accessor for the vectors
*/
public OnHeapHnswGraph build(RandomAccessVectorValues vectors) throws
IOException {
- if (vectors == vectorValues) {
+ if (vectors == this.vectors) {
Review Comment:
may be call a function parameter something different from `vectors` (e.g.
`pvectors`), otherwise gets confused with `this.vectors`?
And also in `addVectors` function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
