uschindler commented on code in PR #11917:
URL: https://github.com/apache/lucene/pull/11917#discussion_r1021728743
##########
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##########
@@ -85,25 +85,23 @@ public class MMapDirectory extends FSDirectory {
* Argument for {@link #setPreload(BiPredicate)} that configures all files
to be preloaded upon
* opening them.
*/
- public static final BiPredicate<String, IOContext> PRELOAD_ALL_FILES =
- (filename, context) -> true;
+ public static final BiPredicate<String, IOContext> ALL_FILES = (filename,
context) -> true;
/**
* Argument for {@link #setPreload(BiPredicate)} that configures no files to
be preloaded upon
* opening them.
*/
- public static final BiPredicate<String, IOContext> PRELOAD_NO_FILES =
- (filename, context) -> false;
+ public static final BiPredicate<String, IOContext> NO_FILES = (filename,
context) -> false;
/**
* Argument for {@link #setPreload(BiPredicate)} that configures all files
that use the {@link
* IOContext#LOAD} to be preloaded upon opening them. This is the default.
*/
- public static final BiPredicate<String, IOContext>
PRELOAD_BASED_ON_IO_CONTEXT =
+ public static final BiPredicate<String, IOContext> BASED_ON_IO_CONTEXT =
(filename, context) -> context.load;
private boolean useUnmapHack = UNMAP_SUPPORTED;
- private BiPredicate<String, IOContext> preload = PRELOAD_BASED_ON_IO_CONTEXT;
+ private BiPredicate<String, IOContext> preload = BASED_ON_IO_CONTEXT;
Review Comment:
maybe `BASED_ON_LOAD_IO_CONTEXT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
