benwtrent commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1334127223
@jpountz > which I don't like much for only two types that need to be supported? I do think we will add more types in the future. Specifically `binary` which can use an optimized hamming distance. This is useful for image search. Splitting it all up like this is a big effort but I suppose its how it should have bene from the beginning. Frustrating to block https://github.com/apache/lucene/pull/11860 for this. I will see about iterating on this refactor and see what the fallout is. @rmuir if you have any further opinions on how you think this should look, let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
