benwtrent commented on PR #12004: URL: https://github.com/apache/lucene/pull/12004#issuecomment-1346600559
> Since we're changing this stuff, I wonder if BytesRef is the right abstraction for a vector of bytes or if we should switch to a plain byte[] I adjusted the query API there and am still using `BytesRef` internally. The reason for using `BytesRef` still internally is because we are still overloading `binaryValue()` for getting the byte vector. I hope to change this in a following PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
