rmuir commented on PR #12013: URL: https://github.com/apache/lucene/pull/12013#issuecomment-1348842317
Yeah, I'm highly suspicious of this cache. I dug into this and found that previously stored fields (!) were used for this lookup. So no surprise there was a cache around it, since this is a slow approach!!! But @gautamworah96 fixed this, and these days BinaryDocValues are used instead: see #10490 IMO there is no sense in caching BinaryDocValues lookups into the heap, it is already mmap'd and the operating system will do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
