rmuir commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1350455204
Simple package-private `static` method to turn on the pickiness should do it. I don't want to see 100 new constructors/abstractions added with booleans, just because antlr made a bad decision. Our APIs should not have to suffer for it. Don't care what java developers or static analysis tools or whatever else wants to say about it: minimal abstractions here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
