twosom commented on code in PR #12047:
URL: https://github.com/apache/lucene/pull/12047#discussion_r1059413652
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseNumberFilter.java:
##########
@@ -39,9 +39,9 @@
* <p>Notice that this analyzer uses a token composition scheme and relies on
punctuation tokens
* being found in the token stream. Please make sure your {@link
JapaneseTokenizer} has {@code
* discardPunctuation} set to false. In case punctuation characters, such as ．
(U+FF0E FULLWIDTH
- * FULL STOP), is removed from the token stream, this filter would find input
tokens tokens ３ and ２千
Review Comment:
removed repeated words `tokens tokens`.
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseNumberFilter.java:
##########
@@ -59,8 +59,8 @@
* <li>15,7 becomes 157 (be aware of this weakness)
* </ul>
*
- * <p>Tokens preceded by a token with {@link PositionIncrementAttribute} of
zero are left left
Review Comment:
removed repeated words `left left`
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/completion/CharSequenceUtils.java:
##########
@@ -72,7 +72,7 @@ public static boolean isFullWidthLowercaseAlphabet(char ch) {
return ch >= 0xff41 && ch <= 0xff5a;
}
- /** Convert all hiragana in a string into kanataka */
Review Comment:
fix spelling `kanataka` to `katakana`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
