zhaih commented on code in PR #12034:
URL: https://github.com/apache/lucene/pull/12034#discussion_r1060863978
##########
lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java:
##########
@@ -314,19 +314,15 @@ private static TermStates adjustFrequencies(
IndexReaderContext readerContext, TermStates ctx, int artificialDf, long
artificialTtf)
throws IOException {
List<LeafReaderContext> leaves = readerContext.leaves();
- final int len;
- if (leaves == null) {
- len = 1;
- } else {
- len = leaves.size();
- }
TermStates newCtx = new TermStates(readerContext);
- for (int i = 0; i < len; ++i) {
- TermState termState = ctx.get(leaves.get(i));
- if (termState == null) {
- continue;
+ if (leaves != null) {
Review Comment:
I checked the implementations of the `IndexReaderContext#leaves()` method
and seems it will never return `null`.
So we probably even don't need this check here, instead could you help add
the doc in the `IndexReaderContext#leaves()` method saying it should never
return null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
