jpountz commented on code in PR #12194:
URL: https://github.com/apache/lucene/pull/12194#discussion_r1129692954
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##########
@@ -414,6 +416,13 @@ public int nextDoc() throws IOException {
return advance(doc + 1);
}
+ @Override
+ public int peekNextNonMatchingDocID() {
+ // TODO not exercised by wikimedium10m benchmark
+ // all docs contain values
+ return NO_MORE_DOCS;
Review Comment:
It should return maxDoc rather than NO_MORE_DOCS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
