romseygeek commented on code in PR #12222:
URL: https://github.com/apache/lucene/pull/12222#discussion_r1164024337
##########
lucene/highlighter/src/test/org/apache/lucene/search/vectorhighlight/TestSimpleFragmentsBuilder.java:
##########
@@ -226,7 +226,7 @@ public void testDiscreteMultiValueHighlighting() throws
Exception {
result = sfb.createFragments(reader, 0, F, ffl, 3);
assertEquals(2, result.length);
assertEquals("text to <b>highlight</b>", result[0]);
- assertEquals("<b>highlight</b> other text", result[1]);
+ assertEquals("<b>highlight</b> other", result[1]);
Review Comment:
Reading again, I see now that you covered this in your opening comment,
sorry! I'm not sure it's the correct behaviour though. Maybe we need to take
into account if this is the final possible text?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
