benwtrent commented on issue #12219:
URL: https://github.com/apache/lucene/issues/12219#issuecomment-1523800849
OK, I think this design would look like this:
- When creating the format, a similarity function can be optionally provided
- The vector similarity function will be a new java interface
- We will default to the same default as the current vector similarity
enumeration.
- Add a new `enum` to the existing vector similarity enumeration indicating
`DEFAULT` that indicates that the format similarity interface must be used. The
implementation of this enum will throw `UnsupportedOperationException` for its
similarity functions.
- Add a vector similarity parameter for the vector reader & writer that the
format will provide.
- If we didn't do this, there would have to be some serialization support
for storing custom vector similarity functions, this seems weird to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
