alessandrobenedetti commented on PR #12257:
URL: https://github.com/apache/lucene/pull/12257#issuecomment-1536110119
@zhaih , @jimczi take a look to my last commit, it's intended as a draft,
just to spark additional discussion, it's not meant in no way to
override/diminish your work.
The rationale is to force users to choose the searcher depending on the
graph they use, in this way, a non-thread safe execution will fail at compile
time.
Tests should be green and if you like the idea, we shouldn't need the
comment "* <p>Note: if you want to search {@link OnHeapHnswGraph} in a
thread-safety manner, please
* consider using {@link OnHeapHnswGraphSearcher}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
