tang-hi commented on PR #12277: URL: https://github.com/apache/lucene/pull/12277#issuecomment-1539327055
> NumberFormatException @rmuir OH! I didn't verify whether NumberFormatException is a subclass of IllegalArgumentException. Upon reviewing [RegExp.java](https://github.com/apache/lucene/blob/a39885fdab93c4cbbcab8f3112c9783a05ca15a9/lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java#LL1215C7-L1233C10), I noticed that it catches the NumberFormatException and rethrows it as an IllegalArgumentException. I followed the same approach in my code. However, considering your feedback, it might be more appropriate to remove this try-catch block. What are your thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
