alessandrobenedetti commented on code in PR #12246:
URL: https://github.com/apache/lucene/pull/12246#discussion_r1194809968
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/Word2VecSynonymProvider.java:
##########
@@ -85,7 +86,7 @@ public List<TermAndBoost> getSynonyms(
SIMILARITY_FUNCTION,
hnswGraph,
null,
- word2VecModel.size());
+ NO_LIMIT_ON_VISITED_NODES);
Review Comment:
Thanks @zhaih ! I would suggest you close this PR as soon as the other two
are merged.
The one about concurrent problems, to be honest I would not wait further and
proceed merging, for https://github.com/apache/lucene/pull/12235 I am not sure
if you need some additional review, let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
