uschindler commented on code in PR #12301:
URL: https://github.com/apache/lucene/pull/12301#discussion_r1196017521


##########
lucene/core/src/java/org/apache/lucene/util/NamedSPILoader.java:
##########
@@ -110,7 +112,14 @@ public S lookup(String name) {
             + "' does not exist."
             + "  You need to add the corresponding JAR file supporting this 
SPI to your classpath."
             + "  The current classpath supports the following names: "
-            + availableServices());
+            + availableServices()
+            + ((System.getSecurityManager() == null)
+                ? ""
+                : " We have detected that a security manager is installed so 
it is also possible "
+                    + "that the services file in the jar containing the codec 
is inaccessible under the current "
+                    + "security policy. A FilePermission implying 'read' 
access to the "
+                    + "jar containing the 
META-INF/services/org.apache.lucene.codec.Codec file is necessary. "

Review Comment:
   Please don't mention "Codec" here, as the NamedSPILoader is used for many 
more than codecs. Please be generic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to