JarvisCraft commented on PR #12295: URL: https://github.com/apache/lucene/pull/12295#issuecomment-1551711212
> So I tend to change the equals methods with instanceof to follow the more modern approach consistently. In this case, I may roll back changes to `equals` methods and create a separate PR replacing their `equals` implementations where it is backwards-compatible (i.e. on final classes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
