uschindler commented on code in PR #12311:
URL: https://github.com/apache/lucene/pull/12311#discussion_r1204255730
##########
gradle/java/memorysegment-mrjar.gradle:
##########
@@ -40,6 +40,7 @@ configure(project(":lucene:core")) {
"-Xlint:-options",
"--patch-module", "java.base=${apijar}",
"--add-exports", "java.base/java.lang.foreign=ALL-UNNAMED",
+ "--add-exports", "java.base/jdk.incubator.vector=ALL-UNNAMED", //
This is a hack, but does it matter
Review Comment:
I agree, it is a hack, but we should maybe say "it's ok because it works for
compilation and has no effect on runtime or classfile output.
Renaming the apijars to be more general should be a separate PR as it needs
aligning and conflict resolution with the already open java 21 one for mmap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
