jbellis commented on PR #12281: URL: https://github.com/apache/lucene/pull/12281#issuecomment-1586196232
> it is enough to do assert Float.isFinite(result), nothing more (no analysis of vector arguments). I don't understand we wouldn't want to include the analysis. This is a result that we expect "can't happen" so it will be extremely valuable to know which scenario it is: - A mistake was introduced into validation of parameters - A new code path happening that didn't do validation properly - Somehow the float32 math didn't work the way we thought it should Basically impossible to tell which scenario without knowing the vector arguments, and there is no cost to having that code on the happy path of everything working since it is only called if the assert fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
