uschindler commented on PR #12363: URL: https://github.com/apache/lucene/pull/12363#issuecomment-1588134825
I tried it out: I reverted the APIJAR changes and only left in following changes: - VectorUtilsProvider.java to enable of 21 - `vectorIncubatorJavaVersions = [ JavaVersion.VERSION_20, JavaVersion.VERSION_21 ] as Set` Everything else was reverted and the tests worked fine. So to me it looks like we can spare the separate implementation as it is 100% identical. The hack does not hurt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
