sgup432 commented on code in PR #12383:
URL: https://github.com/apache/lucene/pull/12383#discussion_r1244295952
##########
lucene/queries/src/test/org/apache/lucene/queries/function/TestFunctionScoreQuery.java:
##########
@@ -322,6 +329,19 @@ private void assertInnerScoreMode(
ScoreMode expectedScoreMode, ScoreMode inputScoreMode,
DoubleValuesSource valueSource)
throws IOException {
final AtomicReference<ScoreMode> scoreModeInWeight = new
AtomicReference<ScoreMode>();
+ final AtomicBoolean scorerCalled = new AtomicBoolean();
Review Comment:
I did check TestTermQuery earlier. But while checking
TestFunctionScoreQuery, I saw it already had support to test for different
scoring types, so thought to add it here instead.
But will add these in TestTermQuery if you feel that, let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
