jpountz commented on code in PR #12407:
URL: https://github.com/apache/lucene/pull/12407#discussion_r1247938650
##########
lucene/core/src/java/org/apache/lucene/search/FieldComparator.java:
##########
@@ -183,10 +183,7 @@ public void setTopValue(Float value) {
@Override
public void setScorer(Scorable scorer) {
- // wrap with a ScoreCachingWrappingScorer so that successive calls to
- // score() will not incur score computation over and
- // over again.
- this.scorer = ScoreCachingWrappingScorer.wrap(scorer);
Review Comment:
Your understanding is correct, we still cache scores for queries sorted by
`Field.SCORE`, but this is done by the collector now, rather than the
comparator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
