LuXugang commented on PR #12405: URL: https://github.com/apache/lucene/pull/12405#issuecomment-1630431580
> I'm not clear if this change is still correct when there is another sort field after the one that gets optimized Thanks @jpountz. Oh, you are right, Sorry for missing this. > My intuition is that the way to fix it would be to allow the comparator to know whether it's the only one The most simply way is to add a default boolean method like `isOnlyComparator` in `LeafFieldComparator` and call this method in `LeafCollector`. Is it a good way or worth for the comparator to know whether it's the only one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
