original-brownbear commented on code in PR #12453:
URL: https://github.com/apache/lucene/pull/12453#discussion_r1271914546
##########
lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java:
##########
@@ -159,6 +159,63 @@ public final long readLong() throws IOException {
}
}
+ @Override
+ public void readFloats(float[] floats, int offset, int len) throws
IOException {
+ int remaining = len;
+ while (remaining > 0) {
+ int cnt = Math.min(buffer.remaining() / Float.BYTES, remaining);
+ buffer.asFloatBuffer().get(floats, offset + len - remaining, cnt);
+ buffer.position(buffer.position() + Float.BYTES * cnt);
+ remaining -= cnt;
+ if (remaining > 0) {
+ if (buffer.hasRemaining()) {
+ floats[offset + len - remaining] = Float.intBitsToFloat(readInt());
+ --remaining;
+ } else {
+ refill();
+ }
+ }
+ }
+ }
+
+ @Override
+ public void readLongs(long[] dst, int offset, int length) throws IOException
{
+ int remaining = length;
+ while (remaining > 0) {
+ int cnt = Math.min(buffer.remaining() / Long.BYTES, remaining);
+ buffer.asLongBuffer().get(dst, offset + length - remaining, cnt);
+ buffer.position(buffer.position() + Long.BYTES * cnt);
+ remaining -= cnt;
+ if (remaining > 0) {
+ if (buffer.hasRemaining()) {
+ dst[offset + length - remaining] = readLong();
+ --remaining;
+ } else {
+ refill();
+ }
+ }
+ }
+ }
+
+ @Override
+ public void readInts(int[] dst, int offset, int length) throws IOException {
+ int remaining = length;
+ while (remaining > 0) {
+ int cnt = Math.min(buffer.remaining() / Integer.BYTES, remaining);
+ buffer.asIntBuffer().get(dst, offset + length - remaining, cnt);
+ buffer.position(buffer.position() + Integer.BYTES * cnt);
+ remaining -= cnt;
+ if (remaining > 0) {
+ if (buffer.hasRemaining()) {
+ dst[offset + length - remaining] = readInt();
+ --remaining;
+ } else {
+ refill();
+ }
+ }
+ }
+ }
+
Review Comment:
++ good call, already had one bug that I only found when running benchmarks.
Added a test for each of the 3 that should cover all the
boundary/alignment/offset cases we can expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
