benwtrent commented on code in PR #12421:
URL: https://github.com/apache/lucene/pull/12421#discussion_r1272563613
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##########
@@ -311,7 +369,6 @@ void searchLevel(
graphSeek(graph, level, topCandidateNode);
int friendOrd;
while ((friendOrd = graphNextNeighbor(graph)) != NO_MORE_DOCS) {
- assert friendOrd < size : "friendOrd=" + friendOrd + "; size=" + size;
Review Comment:
> Fair enough, but is this really worth duplicating a 500 line Searcher
class for, especially since there are other tests now that would break if this
were a problem?
I think this signals that the api abstraction itself is weird :/. I do not
think its worth copying the 500 line searcher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
