gashutos commented on PR #12520: URL: https://github.com/apache/lucene/pull/12520#issuecomment-1699043021
> > > Looks good, can you add a test for missing ~bottom~ minimum value for desc sort as well? > > > > > > Thanks @backslasht . Yes the missing value comparison with bottom (as missing value) is in this test already. > > https://github.com/apache/lucene/blob/34523ec542c21364fffefe726e6226d7f8ffa923/lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java#L219 > > > > The test missing was, missing value comparison with top value when bottom is not set and top value is coming as missing value which I added. > > Sorry, I jumbled the terminologies, I meant a test with missing minimum value for desc sort. Got it, makes sense. Added the test. I kept missing value as Long.MAX_VALUE only for this, it doesnt really matter for our logic for checking its competitiveness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
