eraneverlaw commented on issue #12561: URL: https://github.com/apache/lucene/issues/12561#issuecomment-1726278027
> awesome find, wow, embedded sneaky range in the grammar :) > > Locally I modified the grammar per your suggestion and ran `gradle regenerate`, tests seemed happy. i want to add a simple test for one of your example such as `foo,[email protected]` > > But given how difficult this bug is to chase down, maybe you want to do the honors and make a PR? Otherwise I'm happy to fix it. Thanks so much for looking into it, and the PR offering! But I'm definitely fine with you fixing it, and glad I was able to help. It was pretty hilarious how long we (my colleague and I) looked at the relevant rules, running tests to see if other unexpected characters match, etc, until it suddenly clicked (was even more hilarious when it did click) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
