iverase commented on code in PR #12581:
URL: https://github.com/apache/lucene/pull/12581#discussion_r1333235616
##########
lucene/core/src/java/org/apache/lucene/codecs/StoredFieldsWriter.java:
##########
@@ -182,6 +190,11 @@ public MergeVisitor(MergeState mergeState, int
readerIndex) {
}
}
+ @Override
+ public void binaryField(FieldInfo fieldInfo, DataInput value, int length)
throws IOException {
+ writeField(remap(fieldInfo), value, length);
+ }
+
@Override
public void binaryField(FieldInfo fieldInfo, byte[] value) throws
IOException {
// TODO: can we avoid new BR here?
Review Comment:
Nope, it should not be called, maybe we should assert that it doesn't get
called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
