vsop-479 commented on code in PR #12528:
URL: https://github.com/apache/lucene/pull/12528#discussion_r1333808257
##########
lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java:
##########
@@ -1305,6 +1305,7 @@ private void writeLeafBlockPackedValues(
}
if (lowCardinalityCost <= highCardinalityCost) {
out.writeByte((byte) -2);
+ out.writeByte((byte) sortedDim);
Review Comment:
@iverase This change target both low cardinality and high cardinality.
Because high cardinality already wrote the sortedDim, which can be used in
match phase directly.
So, i only add the sortedDim for low cardinality in BKDWriter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
