dweiss commented on issue #12655:
URL: https://github.com/apache/lucene/issues/12655#issuecomment-1759046099
So it seems something has changed and the javaCompiler property is now
always non-null, causing -X options to be passed to the forked compiler
(instead of -J...). I've changed this check to this:
```
diff --git a/gradle/hacks/turbocharge-jvm-opts.gradle
b/gradle/hacks/turbocharge-jvm-opts.gradle
index 0f404e096b8..e730d878080 100644
--- a/gradle/hacks/turbocharge-jvm-opts.gradle
+++ b/gradle/hacks/turbocharge-jvm-opts.gradle
@@ -57,8 +57,8 @@ allprojects {
// are not part of up-to-date checks but these are internal
JVM flags so we
// don't care.
//
- // Pass VM options via -J only with a custom javaHome AND
when java toolchains are not used.
- if (task.options.forkOptions.javaHome != null &&
task.javaCompiler.getOrNull() == null) {
+ // Pass VM options via -J when a custom javaHome is used
and we're in fork mode.
+ if (task.options.fork && task.options.forkOptions.javaHome
!= null) {
return vmOpts.collect {"-J" + it}
} else {
return vmOpts
```
and it seems to pass for me. The toolchains condition was about dodging some
problem with jdk api regeneration (like generateJdkApiJar19) but I just ran it
with and without RUNTIME_JAVA_HOME and it worked fine... Perhaps @uschindler
will remember what the problem was. I'll commit the above as a temporary
workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
