easyice commented on code in PR #12658:
URL: https://github.com/apache/lucene/pull/12658#discussion_r1357049989
##########
lucene/core/src/java/org/apache/lucene/codecs/PointsWriter.java:
##########
@@ -202,7 +202,7 @@ public long size() {
@Override
public int getDocCount() {
- throw new UnsupportedOperationException();
+ return -1;
Review Comment:
Thank you for catch it, maybe we can add an function like `hasDocCount` to
indicate there has valid `docCount` value, or the other way, catch the
`UnsupportedOperationException` then decide whether to use `docCount` , I
prefer the first one, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
